martinzink commented on code in PR #2044:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2044#discussion_r2486843415
##########
.github/workflows/ci.yml:
##########
@@ -535,6 +535,64 @@ jobs:
with:
name: behavex_output
path: build/behavex_output
+ modular_docker_tests:
+ name: "Modular Docker integration tests (x86_64)"
+ needs: docker_build
+ runs-on: ubuntu-24.04
+ timeout-minutes: 180
+ steps:
+ - id: checkout
+ uses: actions/checkout@v4
+ - id: run_cmake
+ name: Run CMake
+ run: |
+ mkdir build
+ cd build
+ cmake ${DOCKER_CMAKE_FLAGS} ..
+ - name: Download artifact
+ uses: actions/download-artifact@v4
+ with:
+ name: minifi_docker
+ path: build
+ - name: Load Docker image
+ run: |
+ docker load --input ./build/minifi_docker.tar
+ - id: install_deps
+ name: Install dependencies for Docker Verify
+ run: |
+ sudo apt update
+ sudo apt install -y python3-virtualenv
+ - id: free_disk_space
+ run: |
+ # We can gain additional disk space on the Ubuntu runners thanks to
these suggestions:
+ #
https://github.com/actions/runner-images/issues/2840#issuecomment-790492173
+ #
https://github.com/actions/runner-images/issues/2606#issuecomment-772683150
+ sudo rm -rf /usr/share/dotnet
+ sudo rm -rf /usr/local/lib/android
+ sudo rm -rf /opt/ghc
+ sudo rm -rf "/usr/local/share/boost"
+ sudo rm -rf "$AGENT_TOOLSDIRECTORY"
+ - id: test
+ name: Docker Verify
+ working-directory: ./build
+ run: make docker-verify-modular
Review Comment:
good idea, I've changed the typing package imports here
https://github.com/apache/nifi-minifi-cpp/pull/2044/commits/7cb26f05f6806ba8cbb7e40c8ef078352ddc10d6
and added documentation here
https://github.com/apache/nifi-minifi-cpp/pull/2044/commits/6fa1ee3f51471ff12bbf83c1367749f3725678b7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
