adamdebreceni commented on code in PR #1987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1987#discussion_r2526233646
##########
minifi-api/include/minifi-c/minifi-c.h:
##########
@@ -24,24 +24,193 @@ extern "C" {
#include <stddef.h>
#include <stdint.h>
+#include <stdbool.h>
-typedef struct MinifiConfig MinifiConfig;
-typedef struct MinifiExtension MinifiExtension;
+#define STRINGIFY_HELPER(X) #X
+#define STRINGIFY(X) STRINGIFY_HELPER(X)
+
+#define MINIFI_API_MAJOR_VERSION 0
+#define MINIFI_API_MINOR_VERSION 1
+#define MINIFI_API_PATCH_VERSION 0
+#define MINIFI_API_VERSION STRINGIFY(MINIFI_API_MAJOR_VERSION) "."
STRINGIFY(MINIFI_API_MINOR_VERSION) "." STRINGIFY(MINIFI_API_PATCH_VERSION)
+#define MINIFI_API_VERSION_TAG "MINIFI_API_VERSION=[" MINIFI_API_VERSION "]"
+#define MINIFI_NULL nullptr
+#define MINIFI_OWNED
+
+typedef bool MinifiBool;
+#define MINIFI_TRUE true
+#define MINIFI_FALSE false
+
+typedef enum MinifiInputRequirement {
+ MINIFI_INPUT_REQUIRED = 0,
+ MINIFI_INPUT_ALLOWED = 1,
+ MINIFI_INPUT_FORBIDDEN = 2
+} MinifiInputRequirement;
typedef struct MinifiStringView {
const char* data;
size_t length;
} MinifiStringView;
+typedef struct MinifiRelationship {
+ MinifiStringView name;
+ MinifiStringView description;
+} MinifiRelationship;
Review Comment:
added comments, where description not needed,
(MinifiOutputAttributeDefinition::relationships and
MinifiProcessSessionTransfer) I just changed that to MinifiStringView
##########
minifi-api/include/minifi-c/minifi-c.h:
##########
@@ -24,24 +24,193 @@ extern "C" {
#include <stddef.h>
#include <stdint.h>
+#include <stdbool.h>
-typedef struct MinifiConfig MinifiConfig;
-typedef struct MinifiExtension MinifiExtension;
+#define STRINGIFY_HELPER(X) #X
+#define STRINGIFY(X) STRINGIFY_HELPER(X)
Review Comment:
changed
##########
minifi-api/include/minifi-c/minifi-c.h:
##########
@@ -24,24 +24,193 @@ extern "C" {
#include <stddef.h>
#include <stdint.h>
+#include <stdbool.h>
-typedef struct MinifiConfig MinifiConfig;
-typedef struct MinifiExtension MinifiExtension;
+#define STRINGIFY_HELPER(X) #X
+#define STRINGIFY(X) STRINGIFY_HELPER(X)
+
+#define MINIFI_API_MAJOR_VERSION 0
+#define MINIFI_API_MINOR_VERSION 1
+#define MINIFI_API_PATCH_VERSION 0
+#define MINIFI_API_VERSION STRINGIFY(MINIFI_API_MAJOR_VERSION) "."
STRINGIFY(MINIFI_API_MINOR_VERSION) "." STRINGIFY(MINIFI_API_PATCH_VERSION)
+#define MINIFI_API_VERSION_TAG "MINIFI_API_VERSION=[" MINIFI_API_VERSION "]"
+#define MINIFI_NULL nullptr
+#define MINIFI_OWNED
+
+typedef bool MinifiBool;
+#define MINIFI_TRUE true
+#define MINIFI_FALSE false
+
+typedef enum MinifiInputRequirement {
+ MINIFI_INPUT_REQUIRED = 0,
+ MINIFI_INPUT_ALLOWED = 1,
+ MINIFI_INPUT_FORBIDDEN = 2
+} MinifiInputRequirement;
typedef struct MinifiStringView {
const char* data;
size_t length;
} MinifiStringView;
+typedef struct MinifiRelationship {
+ MinifiStringView name;
+ MinifiStringView description;
+} MinifiRelationship;
+
+typedef struct MinifiOutputAttribute {
+ MinifiStringView name;
+ size_t relationships_count;
+ const MinifiRelationship* relationships_ptr;
Review Comment:
changed it to use MinifiStringView
##########
minifi-api/include/minifi-c/minifi-c.h:
##########
@@ -24,24 +24,193 @@ extern "C" {
#include <stddef.h>
#include <stdint.h>
+#include <stdbool.h>
-typedef struct MinifiConfig MinifiConfig;
-typedef struct MinifiExtension MinifiExtension;
+#define STRINGIFY_HELPER(X) #X
+#define STRINGIFY(X) STRINGIFY_HELPER(X)
+
+#define MINIFI_API_MAJOR_VERSION 0
+#define MINIFI_API_MINOR_VERSION 1
+#define MINIFI_API_PATCH_VERSION 0
+#define MINIFI_API_VERSION STRINGIFY(MINIFI_API_MAJOR_VERSION) "."
STRINGIFY(MINIFI_API_MINOR_VERSION) "." STRINGIFY(MINIFI_API_PATCH_VERSION)
+#define MINIFI_API_VERSION_TAG "MINIFI_API_VERSION=[" MINIFI_API_VERSION "]"
+#define MINIFI_NULL nullptr
+#define MINIFI_OWNED
+
+typedef bool MinifiBool;
+#define MINIFI_TRUE true
+#define MINIFI_FALSE false
+
+typedef enum MinifiInputRequirement {
+ MINIFI_INPUT_REQUIRED = 0,
+ MINIFI_INPUT_ALLOWED = 1,
+ MINIFI_INPUT_FORBIDDEN = 2
+} MinifiInputRequirement;
typedef struct MinifiStringView {
const char* data;
size_t length;
} MinifiStringView;
+typedef struct MinifiRelationship {
+ MinifiStringView name;
+ MinifiStringView description;
+} MinifiRelationship;
+
+typedef struct MinifiOutputAttribute {
+ MinifiStringView name;
+ size_t relationships_count;
+ const MinifiRelationship* relationships_ptr;
+ MinifiStringView description;
+} MinifiOutputAttribute;
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
