fgerlits commented on code in PR #1987: URL: https://github.com/apache/nifi-minifi-cpp/pull/1987#discussion_r2510580405
########## core-framework/c-api-framework/include/api/core/logging/Logger.h: ########## @@ -0,0 +1,55 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <algorithm> +#include <iostream> +#include <memory> +#include <mutex> +#include <optional> +#include <sstream> +#include <string> +#include <utility> +#include <vector> + +#include "fmt/chrono.h" +#include "fmt/ostream.h" +#include "fmt/std.h" +#include "minifi-c.h" +#include "utils/Enum.h" +#include "utils/GeneralUtils.h" +#include "minifi-cpp/utils/gsl.h" +#include "utils/SmallString.h" +#include "minifi-cpp/core/logging/Logger.h" Review Comment: This looks like a lot of includes for the code below; please remove those which are not needed. ########## minifi-api/include/minifi-c/minifi-c.h: ########## @@ -24,24 +24,193 @@ extern "C" { #include <stddef.h> #include <stdint.h> +#include <stdbool.h> -typedef struct MinifiConfig MinifiConfig; -typedef struct MinifiExtension MinifiExtension; +#define STRINGIFY_HELPER(X) #X +#define STRINGIFY(X) STRINGIFY_HELPER(X) + +#define MINIFI_API_MAJOR_VERSION 0 +#define MINIFI_API_MINOR_VERSION 1 +#define MINIFI_API_PATCH_VERSION 0 +#define MINIFI_API_VERSION STRINGIFY(MINIFI_API_MAJOR_VERSION) "." STRINGIFY(MINIFI_API_MINOR_VERSION) "." STRINGIFY(MINIFI_API_PATCH_VERSION) +#define MINIFI_API_VERSION_TAG "MINIFI_API_VERSION=[" MINIFI_API_VERSION "]" +#define MINIFI_NULL nullptr +#define MINIFI_OWNED + +typedef bool MinifiBool; +#define MINIFI_TRUE true +#define MINIFI_FALSE false + +typedef enum MinifiInputRequirement { + MINIFI_INPUT_REQUIRED = 0, + MINIFI_INPUT_ALLOWED = 1, + MINIFI_INPUT_FORBIDDEN = 2 +} MinifiInputRequirement; typedef struct MinifiStringView { const char* data; size_t length; } MinifiStringView; +typedef struct MinifiRelationship { + MinifiStringView name; + MinifiStringView description; +} MinifiRelationship; + +typedef struct MinifiOutputAttribute { + MinifiStringView name; + size_t relationships_count; + const MinifiRelationship* relationships_ptr; + MinifiStringView description; +} MinifiOutputAttribute; + +typedef struct MinifiDynamicProperty { + MinifiStringView name; + MinifiStringView value; + MinifiStringView description; + MinifiBool supports_expression_language; Review Comment: Is `supports_expression_language` needed here? I think all dynamic properties support expression language, and there is no way to disable expression languague evaluation on dynamic properties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
