martinzink commented on code in PR #2073:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2073#discussion_r2538418965
##########
libminifi/test/unit/LogMetricsPublisherTests.cpp:
##########
@@ -49,6 +49,7 @@ class LogPublisherTestFixture {
LogPublisherTestFixture& operator=(const LogPublisherTestFixture&) = delete;
~LogPublisherTestFixture() {
+ publisher_.reset();
minifi::utils::file::delete_dir(provenance_repo_->getDirectory());
minifi::utils::file::delete_dir(flow_file_repo_->getDirectory());
LogTestController::getInstance().reset();
Review Comment:
I couldnt verify 100%, but I think the problem lied here that we called
reset on the LogTestController whilst the publisher was still logging left and
right on a separate thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]