szaszm commented on code in PR #2073:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2073#discussion_r2538426516
##########
libminifi/test/unit/LogMetricsPublisherTests.cpp:
##########
@@ -49,6 +49,7 @@ class LogPublisherTestFixture {
LogPublisherTestFixture& operator=(const LogPublisherTestFixture&) = delete;
~LogPublisherTestFixture() {
+ publisher_.reset();
Review Comment:
I think an explanation on how and why the deletion order matters would be
useful. Without the explicit reset call, I think the deletion would happen
first after the destructor body, as members get deleted in reverse order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
