fgerlits commented on code in PR #2069:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2069#discussion_r2547201625
##########
extensions/standard-processors/tests/unit/ConfigurationTests.cpp:
##########
@@ -15,12 +15,27 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+#include <unordered_set>
+
#include "unit/TestBase.h"
#include "unit/Catch.h"
-
#include "properties/Configuration.h"
#include "utils/Environment.h"
+namespace {
+bool fileContentsMatch(const std::filesystem::path& file_name, const
std::unordered_set<std::string>& expected_contents) {
Review Comment:
I have renamed the function to `settingsInFileAreAsExpected()` and changed
the `while` loop to a `for` loop in fb3cdef96c838bc0fee5f0368364a8b1e2ab151f
I don't think the `move` would be correct here, since we would reuse `line`
after we moved from it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
