szaszm commented on code in PR #2069:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2069#discussion_r2589009897


##########
README.md:
##########
@@ -457,8 +457,22 @@ The performance tests can similarly be enabled. To execute 
them and see their ou
 $ ctest --verbose -L performance
 ```
 
+
 ### Configuring
-The 'conf' directory in the installation root contains a template config.yml 
document, minifi.properties, and minifi-log.properties. Please see our 
[Configuration document](CONFIGURE.md) for details on how to configure agents.
+The 'conf' directory in the installation root contains all configuration files.
+
+The files conf/minifi.properties, conf/minifi-log.properties and 
conf/minifi-uid.properties contain key-value pair configuration settings;
+these are the default settings supplied by the latest MiNiFi version. If you 
would like to modify these, you should create a corresponding
+.d directory (e.g. conf/minifi.properties.d) and put your settings in a new 
file inside this directory. These files are read and applied
+in lexicographic order, after the default settings file.
+The Windows installer creates a 
conf/minifi.properties.d/10_installer_properties file, which contains C2 
connection settings.

Review Comment:
   The files under minifi.properties.d should have the .properties extension 
too by convention, but it's OK if the minifi service doesn't enforce this and 
reads all files under the directory.
   ```suggestion
   The Windows installer creates a 
conf/minifi.properties.d/10_installer.properties file, which contains C2 
connection settings.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to