dan-s1 commented on code in PR #10567:
URL: https://github.com/apache/nifi/pull/10567#discussion_r2566661149
##########
nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-service-shared/src/main/java/org/apache/nifi/kafka/service/Kafka3ConnectionService.java:
##########
@@ -214,8 +218,18 @@ protected List<PropertyDescriptor>
getSupportedPropertyDescriptors() {
@Override
protected PropertyDescriptor getSupportedDynamicPropertyDescriptor(final
String propertyDescriptorName) {
+ final String propertyName;
+ final String propertyType;
+ if (isSaslExtensionProperty(propertyDescriptorName)) {
+ propertyName =
removeSaslExtensionPropertyPrefix(propertyDescriptorName);
+ propertyType = "SASL Extension";
+ } else {
+ propertyName = propertyDescriptorName;
+ propertyType = "Kafka Configuration";
+ }
+
return new PropertyDescriptor.Builder()
- .description("Specifies the value for '" +
propertyDescriptorName + "' Kafka Configuration.")
+ .description("Specifies the value for '" + propertyName + "' "
+ propertyType + ".")
Review Comment:
This may be easier to read
```suggestion
.description("Specifies the value for '%s'
%s.".formatted(propertyName, propertyType))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
