turcsanyip commented on code in PR #10567:
URL: https://github.com/apache/nifi/pull/10567#discussion_r2571956694


##########
nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-shared/src/main/java/org/apache/nifi/kafka/shared/validation/DynamicPropertyValidator.java:
##########
@@ -48,10 +50,12 @@ public ValidationResult validate(final String subject, 
final String input, final
 
         if (subject.startsWith(PARTITIONS_PROPERTY_PREFIX)) {
             builder.valid(true);
+        } else if (subject.startsWith(SASL_EXTENSION_PROPERTY_PREFIX)) {
+            builder.valid(true);
         } else {

Review Comment:
   These are unrelated concepts, so I did not want to combine them, even with 
minimal code duplication. Also, the `PARTITIONS_PROPERTY_PREFIX` is a leftover 
from the old Kafka processors and it is not supported at the moment. It will be 
re-added in https://github.com/apache/nifi/pull/10538. I would defer to that PR 
to finalize it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to