exceptionfactory commented on code in PR #10569:
URL: https://github.com/apache/nifi/pull/10569#discussion_r2566998392
##########
nifi-extension-bundles/nifi-snowflake-bundle/nifi-snowflake-services/src/main/java/org/apache/nifi/snowflake/service/StandardSnowflakeIngestManagerProviderService.java:
##########
@@ -58,7 +58,7 @@ public class StandardSnowflakeIngestManagerProviderService
extends AbstractContr
public static final PropertyDescriptor HOST_URL = new
PropertyDescriptor.Builder()
.name("Snowflake URL")
.description("Example host url:
[account-locator].[cloud-region].[cloud]" +
ConnectionUrlFormat.SNOWFLAKE_HOST_SUFFIX)
- .addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+ .addValidator(StandardValidators.URL_VALIDATOR)
Review Comment:
Although the property name includes `URL`, actual usage does not appear to
be a URL, so this change should be reverted.
##########
nifi-extension-bundles/nifi-atlassian-bundle/nifi-atlassian-extensions/src/main/java/org/apache/nifi/atlassian/bitbucket/BitbucketFlowRegistryClient.java:
##########
@@ -49,7 +49,7 @@ public class BitbucketFlowRegistryClient extends
AbstractGitFlowRegistryClient {
static final PropertyDescriptor BITBUCKET_API_URL = new
PropertyDescriptor.Builder()
.name("Bitbucket API Instance")
.description("The Bitbucket API host or base URL (for example,
api.bitbucket.org for Cloud or https://bitbucket.example.com for Data Center)")
- .addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+ .addValidator(StandardValidators.URL_VALIDATOR)
Review Comment:
As shown in the description, this can be a host or URL, so the validator
change should be reverted.
##########
nifi-extension-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java:
##########
@@ -95,7 +95,7 @@ public class RestLookupService extends
AbstractControllerService implements Reco
"not flowfile attributes.")
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.required(true)
- .addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+ .addValidator(StandardValidators.URI_LIST_VALIDATOR)
Review Comment:
This looks like it should be a single URL, not a URL List?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
