dan-s1 commented on code in PR #10569:
URL: https://github.com/apache/nifi/pull/10569#discussion_r2567123794
##########
nifi-extension-bundles/nifi-atlassian-bundle/nifi-atlassian-extensions/src/main/java/org/apache/nifi/atlassian/bitbucket/BitbucketFlowRegistryClient.java:
##########
@@ -49,7 +49,7 @@ public class BitbucketFlowRegistryClient extends
AbstractGitFlowRegistryClient {
static final PropertyDescriptor BITBUCKET_API_URL = new
PropertyDescriptor.Builder()
.name("Bitbucket API Instance")
.description("The Bitbucket API host or base URL (for example,
api.bitbucket.org for Cloud or https://bitbucket.example.com for Data Center)")
- .addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+ .addValidator(StandardValidators.URL_VALIDATOR)
Review Comment:
In the URL_VALIDATOR there is a regex for a host named `HOST_PATTERN`.
Couldn't we have here a custom validator to match either against a host using
that regex (probably cutting and pasting that regex) or matching a URL using
the URL_VALIDATOR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
