[
https://issues.apache.org/jira/browse/NIFI-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862046#comment-15862046
]
ASF GitHub Bot commented on NIFI-3454:
--------------------------------------
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1497
@ottobackwards Reviewed the changes. Confirmed that both test runs
successfully even if there's a .DS_Store file in the test input directory. +1
Please note that when you submit a PR for a JIRA, push the "submit patch"
button to move JIRA status forward to "Patch Available". This ensure other
developers to know it's ready for PR.
https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-CodeReviewProcess
I'm going to merge this. Thank you for you contributing!
> Tests should consistently use the FileNameFilter when reading file names from
> directories
> -----------------------------------------------------------------------------------------
>
> Key: NIFI-3454
> URL: https://issues.apache.org/jira/browse/NIFI-3454
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.1.1
> Environment: Mac OS X ( any version ) Java 1.8.0_31 Maven 3.3.9
> Reporter: Otto Fowler
>
> DS_Store files [https://en.wikipedia.org/wiki/.DS_Store] may be present in
> any directory on Mac OS X.
> Any call made to getURLsForClasspath or getCustomClassLoader passing
> directories an not paths to jars for modules will return these files as urls
> unless they are specifically filtered out using the FileNameFilter parameter.
> The FileNameFilter parameter to these functions can be used to protect
> against this, and be sure the URL's returned are for the expected items. In
> fact there is a function getJarFilenameFilter in the TestClassloaderUtils
> already, that is used by the getCustomClassloader tests.
> This function should be used in all of the tests that pass in directories and
> not paths that are to jar files. Without it, NiFi builds that enable tests
> will fail on Mac OS X if .DS_Store files exist in the testing directory.
> This problem also effects TestIdentifyMimeType.java, where it is doing a
> directory listing, and should ignore "." files.
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
