[
https://issues.apache.org/jira/browse/NIFI-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862047#comment-15862047
]
ASF subversion and git services commented on NIFI-3454:
-------------------------------------------------------
Commit 5cfba6ace324d3537bf70f5c76f883f380503a10 in nifi's branch
refs/heads/master from [~ottobackwards]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=5cfba6a ]
NIFI-3454: Use FileNameFilter to make test consistent
use the FileNameFilter when not passing down explit jar paths
Filter out ^. files when reading lists of files from directories
Signed-off-by: Koji Kawamura <[email protected]>
> Tests should consistently use the FileNameFilter when reading file names from
> directories
> -----------------------------------------------------------------------------------------
>
> Key: NIFI-3454
> URL: https://issues.apache.org/jira/browse/NIFI-3454
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.1.1
> Environment: Mac OS X ( any version ) Java 1.8.0_31 Maven 3.3.9
> Reporter: Otto Fowler
>
> DS_Store files [https://en.wikipedia.org/wiki/.DS_Store] may be present in
> any directory on Mac OS X.
> Any call made to getURLsForClasspath or getCustomClassLoader passing
> directories an not paths to jars for modules will return these files as urls
> unless they are specifically filtered out using the FileNameFilter parameter.
> The FileNameFilter parameter to these functions can be used to protect
> against this, and be sure the URL's returned are for the expected items. In
> fact there is a function getJarFilenameFilter in the TestClassloaderUtils
> already, that is used by the getCustomClassloader tests.
> This function should be used in all of the tests that pass in directories and
> not paths that are to jar files. Without it, NiFi builds that enable tests
> will fail on Mac OS X if .DS_Store files exist in the testing directory.
> This problem also effects TestIdentifyMimeType.java, where it is doing a
> directory listing, and should ignore "." files.
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
