[
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865042#comment-15865042
]
ASF GitHub Bot commented on NIFI-3446:
--------------------------------------
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1478#discussion_r100958463
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java
---
@@ -225,33 +208,17 @@ private StandardFlowService(
@Override
public void saveFlowChanges() throws IOException {
- writeLock.lock();
- try {
- dao.save(controller);
- } finally {
- writeLock.unlock();
- }
+ dao.save(controller);
}
@Override
public void saveFlowChanges(final OutputStream outStream) throws
IOException {
- writeLock.lock();
- try {
- dao.save(controller, outStream);
- } finally {
- writeLock.unlock();
- }
+ dao.save(controller, outStream);
--- End diff --
this no longer has write lock protection
> Make FlowConfigurationDAO Pluggable
> -----------------------------------
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.2.0
> Reporter: Peter Wicks
> Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving
> more of the functionality into FlowConfigurationDAO, allows users to override
> (optional) properties in nifi.properties.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
