[
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865040#comment-15865040
]
ASF GitHub Bot commented on NIFI-3446:
--------------------------------------
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1478#discussion_r100959147
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/persistence/FlowConfigurationDAO.java
---
@@ -25,11 +25,41 @@
import org.apache.nifi.controller.UninheritableFlowException;
import org.apache.nifi.controller.serialization.FlowSerializationException;
import
org.apache.nifi.controller.serialization.FlowSynchronizationException;
+import org.apache.nifi.encrypt.StringEncryptor;
+import org.apache.nifi.util.NiFiProperties;
/**
* Interface to define service methods for FlowController configuration.
*/
public interface FlowConfigurationDAO {
+ /**
+ * Performs any initialization needed. This should be called only by
the
+ * framework.
+ * @param encryptor protected property encryptor/decryptor
+ * @param nifiProperties collection of NiFi properties
+ * @throws IOException thrown if Flow Configuration fails to initialize
+ */
+ void initialize(StringEncryptor encryptor, NiFiProperties
nifiProperties) throws IOException;
+
+ /**
+ * Locks the Flow to prevent cross-thread Writeing
+ */
+ void writeProtectFlow();
+
+ /**
+ * Unlocks a Write locked flow
+ */
+ void unWriteProtectFlow();
+
+ /**
+ * Locks the Flow to prevent cross-thread Writeing
+ */
+ void readProtectFlow();
--- End diff --
copy/paste error on the read/unread protection javadocs.
> Make FlowConfigurationDAO Pluggable
> -----------------------------------
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.2.0
> Reporter: Peter Wicks
> Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving
> more of the functionality into FlowConfigurationDAO, allows users to override
> (optional) properties in nifi.properties.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
