szaszm commented on code in PR #2061:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2061#discussion_r2662012616
##########
extensions/standard-processors/tests/features/defragtextflowfiles.feature:
##########
@@ -28,18 +26,20 @@ Feature: DefragmentText can defragment fragmented data from
TailFile
And a file with filename "test_file_two.log" and content "<input_two>" is
present in "/tmp/input"
And a DefragmentText processor with the "Pattern" property set to
"<pattern>"
And the "Pattern Location" property of the DefragmentText processor is set
to "<pattern location>"
+ And DefragmentText is EVENT_DRIVEN
And a PutFile processor with the name "SuccessPut" and the "Directory"
property set to "/tmp/output"
+ And SuccessPut is EVENT_DRIVEN
And the "success" relationship of the MultiTail processor is connected to
the DefragmentText
And the "success" relationship of the DefragmentText processor is
connected to the SuccessPut
-
+ And SuccessPut's success relationship is auto-terminated
When all instances start up
- Then flowfiles with these contents are placed in the monitored directory
in less than 60 seconds: "<success_flow_files>"
+ Then the contents of /tmp/output in less than 60 seconds are:
"<success_flow_files>"
Examples:
| input_one | input_two
| pattern | pattern location |
success_flow_files |
| <1>cat%dog%mouse%<2>apple%banana%<3>English% |
<1>Katze%Hund%Maus%<2>Apfel%Banane%<3>Deutsch% | <[0-9]+> | Start of
Message |
<1>cat%dog%mouse%,<1>Katze%Hund%Maus%,<2>apple%banana%,<2>Apfel%Banane% |
- | <1>cat%dog%mouse%<2>apple%banana%<3>English% |
<1>Katze%Hund%Maus%<2>Apfel%Banane%<3>Deutsch% | <[0-9]+> | End of
Message |
<1>,cat%dog%mouse%<2>,Katze%Hund%Maus%<2>,apple%banana%<3>,Apfel%Banane%<3> |
+ | <1>cat%dog%mouse%<2>apple%banana%<3>English% |
<1>Katze%Hund%Maus%<2>Apfel%Banane%<3>Deutsch% | <[0-9]+> | End of
Message |
<1>,<1>,cat%dog%mouse%<2>,Katze%Hund%Maus%<2>,apple%banana%<3>,Apfel%Banane%<3>
|
Review Comment:
Negative tests are a good practice anyway, to see that the code fails when
it's supposed to fail, and a partial validation of the test framework is just a
happy side effect. But if it's too cumbersome to write, I'm not gonna insist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
