lordgamez commented on code in PR #2061:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2061#discussion_r2664277297
##########
behave_framework/src/minifi_test_framework/containers/container.py:
##########
@@ -279,10 +282,24 @@ def _verify_file_contents_in_running_container(self,
directory_path: str, expect
if exit_code != 0:
error_message = f"Command to read file '{path}' failed with
exit code {exit_code}"
logging.error(error_message)
- return False
+ return None
actual_file_contents.append(content)
+ return actual_file_contents
+
+ def _verify_file_contents_in_running_container(self, directory_path: str,
expected_contents: list[str]) -> bool:
+ if not self.not_empty_dir_exists(directory_path):
Review Comment:
Updated in
https://github.com/apache/nifi-minifi-cpp/pull/2061/commits/ac43cb931f900b6dfee470fa9140c6ef511f68ed
##########
extensions/standard-processors/tests/features/steps/steps.py:
##########
@@ -33,3 +35,19 @@ def step_impl(context: MinifiTestContext):
@step("a Syslog client with UDP protocol is setup to send logs to minifi")
def step_impl(context):
context.containers["syslog-udp"] = SyslogContainer("udp", context)
+
+
+@step(u'there is an accessible PLC with modbus enabled')
Review Comment:
Updated in
https://github.com/apache/nifi-minifi-cpp/pull/2061/commits/ac43cb931f900b6dfee470fa9140c6ef511f68ed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
