lordgamez commented on code in PR #2088:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2088#discussion_r2737106809
##########
libminifi/include/c2/protocols/RESTSender.h:
##########
@@ -77,6 +77,7 @@ class RESTSender : public RESTProtocol, public C2Protocol {
RequestEncoding req_encoding_ = RequestEncoding::none;
private:
+ std::chrono::milliseconds asset_download_timeout_{std::chrono::seconds{0}};
Review Comment:
nitpick: using `0s` as the default value would look cleaner
##########
libminifi/src/c2/C2Agent.cpp:
##########
@@ -321,6 +321,33 @@ struct C2DebugBundleError : public C2TransferError {
using C2TransferError::C2TransferError;
};
+nonstd::expected<void, std::string> fetchAssetAsFile(C2Protocol& protocol,
const std::string& url, const std::filesystem::path& file_path,
std::shared_ptr<core::logging::Logger> logger) {
Review Comment:
Please pass `logger` as a const ref to satisfy clang tidy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
