szaszm commented on code in PR #2088:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2088#discussion_r2737793275


##########
libminifi/include/c2/protocols/RESTSender.h:
##########
@@ -77,6 +77,7 @@ class RESTSender : public RESTProtocol, public C2Protocol {
   RequestEncoding req_encoding_ = RequestEncoding::none;
 
  private:
+  std::chrono::milliseconds asset_download_timeout_{std::chrono::seconds{0}};

Review Comment:
   It's a header, `using namespace std::literals;` would pollute the namespace 
in other translation units too, so I'd leave it like this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to