Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1491#discussion_r101138360
--- Diff:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/util/TlsHelper.java
---
@@ -184,8 +192,27 @@ public static KeyPair generateKeyPair(String
algorithm, int keySize) throws NoSu
return createKeyPairGenerator(algorithm,
keySize).generateKeyPair();
}
- public static JcaPKCS10CertificationRequest
generateCertificationRequest(String requestedDn, KeyPair keyPair, String
signingAlgorithm) throws OperatorCreationException {
+ public static JcaPKCS10CertificationRequest
generateCertificationRequest(String requestedDn, String domainAlternativeName,
+ KeyPair keyPair, String signingAlgorithm) throws
OperatorCreationException {
JcaPKCS10CertificationRequestBuilder
jcaPKCS10CertificationRequestBuilder = new
JcaPKCS10CertificationRequestBuilder(new X500Name(requestedDn),
keyPair.getPublic());
+
+ // add Subject Alternative Name
+ if(StringUtils.isNotBlank(domainAlternativeName)) {
--- End diff --
Variable should be plural as it can contain multiple entries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
