Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1491#discussion_r101138547
--- Diff:
nifi-toolkit/nifi-toolkit-tls/src/test/java/org/apache/nifi/toolkit/tls/service/client/TlsCertificateSigningRequestPerformerTest.java
---
@@ -106,7 +106,7 @@ public void setup() throws GeneralSecurityException,
OperatorCreationException,
when(tlsClientConfig.getPort()).thenReturn(testPort);
when(tlsClientConfig.createCertificateSigningRequestPerformer()).thenReturn(tlsCertificateSigningRequestPerformer);
when(tlsClientConfig.getSigningAlgorithm()).thenReturn(TlsConfig.DEFAULT_SIGNING_ALGORITHM);
- JcaPKCS10CertificationRequest jcaPKCS10CertificationRequest =
TlsHelper.generateCertificationRequest(tlsClientConfig.getDn(), keyPair,
TlsConfig.DEFAULT_SIGNING_ALGORITHM);
+ JcaPKCS10CertificationRequest jcaPKCS10CertificationRequest =
TlsHelper.generateCertificationRequest(tlsClientConfig.getDn(), null, keyPair,
TlsConfig.DEFAULT_SIGNING_ALGORITHM);
--- End diff --
There should be new tests to cover the added functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
