markap14 commented on PR #11164: URL: https://github.com/apache/nifi/pull/11164#issuecomment-4434317344
[claude-opus-4.7] @pvillard31 thanks for the latest round of feedback. The new commit (2c0e041) addresses your remaining comments and rebases onto current `main`: - `ThreadDumpTask` now logs at debug rather than silently swallowing the cleanup `IOException`, so a recurring failure to delete `nifi-thread-dump-*` directories is discoverable. - On the thread-name-after-rename question: after some prototyping we decided not to refresh the virtual thread's name inside the scheduling loop. Resetting the name on every iteration adds an allocation-heavy `buildThreadName` call to a hot path that may run at zero scheduling period, and cache-and-compare workarounds add complexity for what is purely a diagnostic nicety. The name resolved at scheduling time (component name + type + id + parent-group name + task index) still contains the immutable component id, so threads remain identifiable in dumps. If the user wants the new name reflected, stopping and restarting the component is sufficient. The earlier review-feedback commit (0abffe2) is also still on the branch and covers the prior round of comments: atomic schedule rollback (#3), thread tracking + `shutdown()` interrupt with `FlowController` kill-path hook (#5), `setMaxThreadCount` synchronization (#2), and the response on `runOnce` polling (#1). Force push was required to incorporate the `main` rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
