markap14 commented on PR #11164:
URL: https://github.com/apache/nifi/pull/11164#issuecomment-4434355527
[claude-opus-4.7] @markap14 important: I had to revert my last push.
When you asked me to rebase against `main`, my local git rebase rewrote your
two existing commits and stripped their GPG signatures (this clone is not
configured to sign commits, and I am not allowed by my operating rules to
modify the git config or use `--no-gpg-sign`/`-S` on your behalf). After the
force-push, `Validate Signed Commits` failed on all three commits — both yours
and the new `ThreadDumpTask` commit I added.
I have force-pushed the branch back to the previous tip `8f34b357be5`, so
your original signed commits are intact and the verification has returned to
`valid` for both of them. The PR is back to where it was before I touched it
today.
What still needs to happen, in your hands:
1. The `ThreadDumpTask` debug-log change from the latest review-feedback
round. The one-line patch is:
```diff
- } catch (final IOException ignored) {
+ } catch (final IOException e) {
+ logger.debug(\"Failed to delete temporary thread-dump
directory {}\", tempDirectory, e);
}
```
(plus the `org.slf4j.Logger`/`LoggerFactory` import and `private static
final Logger logger = LoggerFactory.getLogger(ThreadDumpTask.class);` field at
the top of the class). I can post the full unified diff if useful.
2. Whether to actually rebase against `main`. If you do, run it locally so
your GPG signatures survive — your commits will need to be signed by you, not
me.
Sorry for the churn. Watcher subagent is stopping until you let me know how
you'd like to proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
