Ferenc Gerlits created MINIFICPP-2814:
-----------------------------------------
Summary: Remove the need for adding an == operator to
rocksdb::DBOptions
Key: MINIFICPP-2814
URL: https://issues.apache.org/jira/browse/MINIFICPP-2814
Project: Apache NiFi MiNiFi C++
Issue Type: Improvement
Reporter: Ferenc Gerlits
In {{{}RocksDbInstance::registerColumnConfig{}}}, we check if the RocksDB
options update has caused any change by comparing the old and new {{DBOptions}}
objects using a {{!=}} operator:
[https://github.com/apache/nifi-minifi-cpp/blob/7699fea00b2c55fc02589fe42692e9df4b24f5a2/extensions/rocksdb-repos/database/RocksDbInstance.cpp#L70]
But {{rocksdb::DBOptions}} does not have an {{==}} (or {{{}!={}}}) operator, so
we add one ourselves. This is not great, since we should not be adding
functions to external dependencies. Also a defaulted {{==}} operator may not be
correct, since the struct contains pointers.
Is there a better way to check if the update has caused any change, without the
need for an {{==}} operator?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
