ing-mattioni opened a new pull request, #11242: URL: https://github.com/apache/nifi/pull/11242
…hAMQP <!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-15934](https://issues.apache.org/jira/browse/NIFI-15934) This pull request updates `PublishAMQP` to improve handling of oversized FlowFiles and AMQP header attributes. `PublishAMQP` reads FlowFile content into a byte array before publishing an AMQP message. Since Java byte arrays require an `int` length, FlowFiles larger than `Integer.MAX_VALUE` cannot be published using this path. This change validates the FlowFile size before attempting byte-array allocation and routes oversized FlowFiles to `failure` with penalization. This pull request also updates AMQP header parsing to ignore empty header keys instead of adding them to the AMQP headers map. P.S. The existing unit test for AMQP header parsing was extended to cover empty header keys. The oversized FlowFile guard is a defensive validation before byte-array allocation; additional targeted coverage may require avoiding real multi-GB content allocation. ## Changes - Validates FlowFile size before extracting message content into a byte array - Routes FlowFiles larger than `Integer.MAX_VALUE` to `failure` with penalization - Uses `Math.toIntExact()` when converting FlowFile size to byte array length - Ignores empty AMQP header keys when parsing AMQP header attributes - Extends AMQP header parsing test coverage for empty header keys # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-15934) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [x] Pull request contains commits signed with a registered key indicating `Verified` status ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 Module-level verification performed: `.\mvnw.cmd -pl :nifi-amqp-processors -am test` Additional verification performed: `.\mvnw.cmd -pl :nifi-amqp-processors -am -P contrib-check install -DskipTests` `.\mvnw.cmd -pl :nifi-amqp-nar -am install -DskipTests` ### Licensing - [x] New dependencies are compatible with the Apache License 2.0 - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files No new dependencies were added. ### Documentation - [x] Documentation formatting appears as expected in rendered files No user-facing documentation files were changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
