exceptionfactory commented on code in PR #11242:
URL: https://github.com/apache/nifi/pull/11242#discussion_r3268000454
##########
nifi-extension-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java:
##########
@@ -95,6 +97,14 @@ public class PublishAMQP extends
AbstractAMQPProcessor<AMQPPublisher> {
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ public static final PropertyDescriptor MAX_OUTBOUND_MESSAGE_BODY_SIZE =
new PropertyDescriptor.Builder()
+ .name("Max Outbound Message Body Size")
+ .description("Maximum body size of outbound messages. FlowFiles
larger than this value are routed to failure without loading content into
memory.")
+ .required(true)
+ .defaultValue("64 MB")
Review Comment:
Is there a general published maximum size of AMQP messages, or some
reference for using 64 MB is the default value?
##########
nifi-extension-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java:
##########
@@ -95,6 +97,14 @@ public class PublishAMQP extends
AbstractAMQPProcessor<AMQPPublisher> {
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ public static final PropertyDescriptor MAX_OUTBOUND_MESSAGE_BODY_SIZE =
new PropertyDescriptor.Builder()
+ .name("Max Outbound Message Body Size")
Review Comment:
I recommend naming this `Maximum Input FlowFile Size` since that it what is
controls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
