lordgamez commented on code in PR #2174:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2174#discussion_r3279778527
##########
extensions/rocksdb-repos/FlowFileRepository.cpp:
##########
@@ -151,7 +151,8 @@ void FlowFileRepository::initialize_repository() {
const auto it = opendb->NewIterator(options);
for (it->SeekToFirst(); it->Valid(); it->Next()) {
utils::Identifier container_id;
- auto eventRead =
FlowFileRecord::DeSerialize(gsl::make_span(it->value()).as_span<const
std::byte>(), content_repo_, container_id);
+ const auto slice = it->value();
+ auto eventRead = FlowFileRecord::DeSerialize(std::span<const
std::byte>(reinterpret_cast<const std::byte*>(slice.data()), slice.size()),
content_repo_, container_id);
Review Comment:
I could only find one instance in the diff and one other instance in a
separate test, fixed in
https://github.com/apache/nifi-minifi-cpp/pull/2174/commits/fa0d11adc25fd5a7d514bc76bf7b726c28a96608
Please point them out if I missed any other instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
