lordgamez commented on code in PR #2174: URL: https://github.com/apache/nifi-minifi-cpp/pull/2174#discussion_r3282483102
########## CMakeLists.txt: ########## @@ -302,7 +301,14 @@ include(GslLite) # Add necessary definitions based on the value of STRICT_GSL_CHECKS, see gsl-lite README for more details list(APPEND GslDefinitions gsl_CONFIG_DEFAULTS_VERSION=1) -list(APPEND GslDefinitionsNonStrict gsl_CONFIG_CONTRACT_VIOLATION_THROWS gsl_CONFIG_NARROW_THROWS_ON_TRUNCATION=1) +list(APPEND GslDefinitions gsl_FEATURE_BYTE=1) +list(APPEND GslDefinitions gsl_CONFIG_NARROW_THROWS_ON_TRUNCATION=1) Review Comment: gsl_CONFIG_NARROW_THROWS_ON_TRUNCATION: Good point, matching the C++ core guidlines sounds good to me, removed it to use the default in https://github.com/apache/nifi-minifi-cpp/pull/2174/commits/a0639e35ad2b4907e97fe10bee74224e59cd7d40 gsl_FEATURE_BYTE: I just realized we do not need this anymore, I thought it is used for something different, but it only provides byte, as_bytes, as_writable_bytes etc. implementations that we already use the std library version of. I must have been a leftover from when older compilers were supported. Removed it in https://github.com/apache/nifi-minifi-cpp/pull/2174/commits/a0639e35ad2b4907e97fe10bee74224e59cd7d40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
