szaszm commented on code in PR #2174:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2174#discussion_r3291517291
##########
extensions/rocksdb-repos/FlowFileRepository.cpp:
##########
@@ -151,7 +151,8 @@ void FlowFileRepository::initialize_repository() {
const auto it = opendb->NewIterator(options);
for (it->SeekToFirst(); it->Valid(); it->Next()) {
utils::Identifier container_id;
- auto eventRead =
FlowFileRecord::DeSerialize(gsl::make_span(it->value()).as_span<const
std::byte>(), content_repo_, container_id);
+ const auto slice = it->value();
+ auto eventRead = FlowFileRecord::DeSerialize(std::span<const
std::byte>(reinterpret_cast<const std::byte*>(slice.data()), slice.size()),
content_repo_, container_id);
Review Comment:
I couldn't find any more either, sorry for exaggerating their prevalence. On
my first review, I got the impression that there are many instances of this
pattern, but there aren't as many as I thought. 2 days ago in my last reply, I
was replying under this assumption, without reviewing all the files again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
