pvillard31 commented on code in PR #11364:
URL: https://github.com/apache/nifi/pull/11364#discussion_r3455513074
##########
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/test/java/org/apache/nifi/processors/network/pcap/TestPCAP.java:
##########
@@ -82,23 +82,23 @@ void testReadBytesFull() {
// Assert the expected byte array values
ByteBuffer buffer = ByteBuffer.wrap(result);
assertEquals(0xa1b2c3d4, buffer.getInt());
- ByteBuffer litteEndianBuffer =
ByteBuffer.wrap(result).order(ByteOrder.LITTLE_ENDIAN);
- litteEndianBuffer.position(4);
+ ByteBuffer littleEndianBuffer =
ByteBuffer.wrap(result).order(ByteOrder.LITTLE_ENDIAN);
+ littleEndianBuffer.position(4);
for (int[] value : PCAP_HEADER_VALUES) {
if (value[1] == 2) {
- assertEquals(value[0], litteEndianBuffer.getShort());
+ assertEquals(value[0], littleEndianBuffer.getShort());
} else {
- assertEquals(value[0], litteEndianBuffer.getInt());
+ assertEquals(value[0], littleEndianBuffer.getInt());
}
}
- assertEquals(packetHeaderValues.get("tsSec"),
litteEndianBuffer.getInt());
- assertEquals(packetHeaderValues.get("tsUsec"),
litteEndianBuffer.getInt());
- assertEquals(packetHeaderValues.get("inclLen"),
litteEndianBuffer.getInt());
- assertEquals(packetHeaderValues.get("origLen"),
litteEndianBuffer.getInt());
+ assertEquals(packetHeaderValues.get("tsSec"),
littleEndianBuffer.getInt());
+ assertEquals(packetHeaderValues.get("tsUsec"),
littleEndianBuffer.getInt());
+ assertEquals(packetHeaderValues.get("inclLen"),
littleEndianBuffer.getInt());
+ assertEquals(packetHeaderValues.get("origLen"),
littleEndianBuffer.getInt());
byte[] body = new byte[30];
- litteEndianBuffer.get(40, body, 0, 30);
- assertArrayEquals(PACKET_DATA, body);
+ littleEndianBuffer.get(40, body, 0, 30);
+ assertArrayEquals(body, PACKET_DATA);
Review Comment:
is it the right order?
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestSplitRecord.java:
##########
@@ -131,7 +131,7 @@ public void testMultipleRecordsPerSplit() throws
InitializationException {
}
@Test
- public void testAllSplitsOneDesintation() throws InitializationException {
+ public void testAllSplitsOneDestintation() throws InitializationException {
Review Comment:
Still a typo
##########
nifi-system-tests/nifi-system-test-extensions-bundle/nifi-system-test-extensions/src/main/java/org/apache/nifi/flowanalysis/StatefulFlowAnalysisRule.java:
##########
@@ -30,30 +30,30 @@
@Stateful(scopes = Scope.LOCAL, description = "Stores the timestamp of the
last initialization")
public class StatefulFlowAnalysisRule extends AbstractFlowAnalysisRule {
- private static final String LAST_ANALYIZE_COMPONENT_TIMESTAMP =
"last.analyze.component.timestamp";
- private static final String LAST_ANALYIZE_PROCESS_GROUP_TIMESTAMP =
"last.analyze.component.timestamp";
+ private static final String LAST_ANALYZE_COMPONENT_TIMESTAMP =
"last.analyze.component.timestamp";
+ private static final String LAST_ANALYZE_PROCESS_GROUP_TIMESTAMP =
"last.analyze.component.timestamp";
Review Comment:
Since we are editing the lines, shouldn't the second variable have a
different value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
