mosermw commented on PR #11364: URL: https://github.com/apache/nifi/pull/11364#issuecomment-4782055922
> > I see a couple of public elements being renamed (the SchemaInstantiationException class and the RepositoryConfiguration.MAINTENANCE_FREQUENCY constant). Any concern there? > > `SchemaInstantiationException` I checked at least the current code base uses it six times. I assumed although I can be wrong that minifi would be the only users of that class. Also `RepositoryConfiguration.MAINTENANCE_FREQUENCY` it is used once and only in `RepositoryConfiguration`. I can revert all of these if there is hesitancy to change these. Please let me know what you would like me to do . I would suggest that modifying public names of any type would have a non-zero chance of breaking other people's custom extensions. Names of unit tests, though, are fair game. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
