szaszm commented on code in PR #2227:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2227#discussion_r3722470018
##########
minifi-api/include/minifi-cpp/agent/agent_docs.h:
##########
@@ -51,39 +57,125 @@ struct ClassDescription {
bool isSingleThreaded_ = false;
};
-struct Components {
- std::vector<ClassDescription> processors;
- std::vector<ClassDescription> controller_services;
- std::vector<ClassDescription> parameter_providers;
- std::vector<ClassDescription> other_components;
+struct BundleCoordinate {
+ std::string name;
+ std::string group_name;
+ std::string version;
+
+ auto operator<=>(const BundleCoordinate& rhs) const = default;
+};
Review Comment:
BundleCoordinate supposedly comes from nifi.
BundleCoordinate:
https://github.com/apache/nifi/blob/main/nifi-framework-api/src/main/java/org/apache/nifi/bundle/BundleCoordinate.java
There is also a Bundle type in nifi-api:
https://github.com/apache/nifi-api/blob/main/src/main/java/org/apache/nifi/flow/Bundle.java
I don't have a strong preference either way, because I don't know how well
or how directly all of this maps to the corresponding NiFi types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
