martinzink commented on code in PR #2227:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2227#discussion_r3727300431
##########
core-framework/include/core/Resource.h:
##########
@@ -57,6 +57,11 @@ class StaticClassType {
#else
auto module_name = "minifi-system";
#endif
+#ifdef MINIFI_EXTENSION_GROUP_NAME
+ auto group_name = MAKESTRING(MINIFI_EXTENSION_GROUP_NAME);
+#else
+ auto group_name = "org.apache.nifi.minifi";
+#endif
Review Comment:
sure thing,
https://github.com/apache/nifi-minifi-cpp/pull/2227/changes/2f49406fee65c9dcf3738559f7c2dc0dc0c3e2ad
since we only defined this in the register_extension macro i had to add this
into almost every tests/cmakelist (anything that includes Resource.h)
##########
extensions/python/PythonCreator.h:
##########
@@ -174,7 +175,8 @@ class PythonCreator : public
minifi::core::CoreComponentImpl {
.inputRequirement_ = toString(processor->getInputRequirement()),
.isSingleThreaded_ = processor->isSingleThreaded()};
-
minifi::ClassDescriptionRegistry::getMutableClassDescriptions()[details].processors.push_back(description);
+ auto& bundle_components =
minifi::ClassDescriptionRegistry::getMutableClassDescriptions().try_emplace(details,
details).first->second;
+ bundle_components.addClassDescription(description,
ResourceType::Processor);
Review Comment:
👍
https://github.com/apache/nifi-minifi-cpp/pull/2227/changes/2f49406fee65c9dcf3738559f7c2dc0dc0c3e2ad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
