Copilot commented on code in PR #2220:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2220#discussion_r3844211899
##########
minifi_rust/minifi_native/src/api/processor_wrappers/flow_file_transform.rs:
##########
@@ -200,3 +213,42 @@ where
}
}
}
+
+#[macro_export]
+macro_rules! unwrap_or_route {
Review Comment:
Because this macro is exported, crate-owned names must use `$crate`. Its
expansions currently reference invocation-site `TransformedFlowFile` and
`error!` names (and one arm hard-codes `minifi_native`), so downstream callers
that import only `unwrap_or_route!`—or rename the dependency—will fail to
compile. Qualify all three arms with `$crate::TransformedFlowFile` and
`$crate::error!`.
##########
minifi_rust/extensions/minifi_rs_playground/src/processors/put_file/unix_permissions.rs:
##########
@@ -0,0 +1,62 @@
+use minifi_native::{MinifiError, PropertyConstraints, PropertySchema,
PropertyType};
Review Comment:
This new source file is missing the Apache license header used by the
surrounding Rust sources (for example, `put_file.rs:1-16` and
`unix_only_properties.rs:1-16`). Add the standard header so the file satisfies
the repository's licensing convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
