martinzink commented on code in PR #2220:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2220#discussion_r3860800378
##########
minifi_rust/minifi_native/src/api/process_context.rs:
##########
@@ -15,115 +15,39 @@
// specific language governing permissions and limitations
// under the License.
-use crate::StandardPropertyValidator::*;
use crate::api::RawControllerService;
use crate::api::component_definition_traits::ComponentIdentifier;
use crate::api::flow_file::FlowFile;
-use crate::api::property::GetControllerService;
-use crate::{
- ControllerServiceApi, ControllerServiceDefinition,
EnableControllerService, GetProperty,
- MinifiError, Property,
-};
-use std::str::FromStr;
-use std::time::Duration;
+use crate::api::property::{ControllerServiceValue, GetControllerService,
PropertySchema};
+use crate::{ControllerServiceApi, EnableControllerService, GetProperty,
MinifiError, Property};
pub trait ProcessContext {
type FlowFile: FlowFile;
- fn get_property(
+ fn get_raw_property<P: PropertySchema + ?Sized>(
&self,
- property: &Property,
+ property: &Property<P>,
flow_file: Option<&Self::FlowFile>,
) -> Result<Option<String>, MinifiError>;
- fn get_bool_property(
+ fn get_raw_controller_service<Cs, P>(
Review Comment:
raw means agent managed in rust context, so there are RawProcessors and
RawControllerServices these are the objects are created and destroyed in minifi
code (via callbacks) these wrap the user written Processors and
ControllerServices (in options) so the user written Processors are created
during schedule and user Written ControllerServices are created during enable.
The C api strictly oeprates with these raw types, but the extensions writer
shouldnt need to know about these.
In property context, since the agent deals with strings only raw_property
means the actual string set, and property is the parsed verified typed object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
