rfellows commented on code in PR #11842:
URL: https://github.com/apache/nifi/pull/11842#discussion_r4393680219
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/state/connector-canvas/connector-canvas.reducer.ts:
##########
@@ -117,9 +121,19 @@ export const connectorCanvasReducer = createReducer(
remoteProcessGroups,
processGroups,
processors,
- connections
+ connections,
+ reconciliationSnapshot,
+ connectedStateChanged
}
) => {
+ const requestedAddedIds = new
Set(reconciliationSnapshot.addedCache);
+ const requestedRemovedIds = new
Set(reconciliationSnapshot.removedCache);
+ const addedCache = connectedStateChanged
Review Comment:
After further review, I agree this is non-blocking. Backend revision
enforcement protects persisted state, and the residual effect is a narrow,
transient canvas inconsistency corrected by polling. No change is requested for
this PR; resolving.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/state/connector-canvas/connector-canvas.reducer.ts:
##########
@@ -48,15 +48,18 @@ function processComponentCollection<E extends { id: string;
revision: Revision }
proposedComponents: E[],
currentComponents: E[],
addedCache: string[],
- removedCache: string[]
+ removedCache: string[],
+ connectedStateChanged: boolean
): E[] {
const currentById = new Map(currentComponents.map((component) =>
[component.id, component]));
const proposedIds = new Set(proposedComponents.map((component) =>
component.id));
const components = proposedComponents
.filter((component) => !removedCache.includes(component.id))
.map((proposedComponent) => {
const currentComponent = currentById.get(proposedComponent.id);
- return currentComponent &&
!hasCurrentOrNewerRevision(currentComponent.revision,
proposedComponent.revision)
+ return currentComponent &&
Review Comment:
After further review, I agree this is non-blocking. Backend revision
enforcement protects persisted state, and the residual effect is a narrow,
transient canvas inconsistency corrected by polling. No change is requested for
this PR; resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
