adamdebreceni commented on code in PR #2231:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2231#discussion_r4562504944
##########
libminifi/include/core/reporting/SiteToSiteProvenanceReportingTask.h:
##########
@@ -28,32 +28,43 @@
#include "core/ProcessSession.h"
#include "RemoteProcessGroupPort.h"
#include "core/logging/LoggerFactory.h"
+#include "core/reporting/ReportingTaskBase.h"
namespace org::apache::nifi::minifi::core::reporting {
-class SiteToSiteProvenanceReportingTask : public
minifi::RemoteProcessGroupPort {
+class SiteToSiteProvenanceReportingTask : public ReportingTaskBase {
public:
- explicit SiteToSiteProvenanceReportingTask(std::shared_ptr<Configure>
configure)
- : minifi::RemoteProcessGroupPort(ReportTaskName, "",
std::move(configure),
- utils::IdGenerator::getIdGenerator()->generate(),
sitetosite::TransferDirection::SEND,
logging::LoggerFactory<SiteToSiteProvenanceReportingTask>::getLogger()) {
+ explicit SiteToSiteProvenanceReportingTask(ReportingTaskMetadata metadata)
+ : ReportingTaskBase{metadata},
+ remote_port_{metadata.name, metadata.uuid,
std::make_unique<RemoteProcessGroupPort>(metadata.name, "", Configure::create(),
+ metadata.uuid, sitetosite::TransferDirection::SEND, metadata.logger)}
+ {
Review Comment:
now the configuration is always fetched from
ProcessContext/ReportingTaskContext and forwarded where needed, not stored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
