adamdebreceni commented on code in PR #2231:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2231#discussion_r4562608821
##########
minifi-api/include/minifi-cpp/core/ProcessContext.h:
##########
@@ -46,14 +47,20 @@ class ProcessorInfo {
class Processor;
-class ProcessContext : public virtual core::VariableRegistry, public virtual
utils::EnableSharedFromThis {
+class ProcessContext : public reporting::ReportingTaskContext, public virtual
core::VariableRegistry, public virtual utils::EnableSharedFromThis {
Review Comment:
I agree that the inheritance here is unwarranted, instead of creating
ComponentContext, I introduced an ReportingTaskContextAdapter forwarding to
ProcessContext, I think it is worth a separate discussion to create
ComponentContext (so we can also see ControllerServiceContext fits into it)
(out of curiousity, what property is satisfied by ReportingTaskContext but
not by ProcessContext to break LSP?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
