fgerlits commented on code in PR #2310:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2310#discussion_r4619132458
##########
bootstrap/cli.py:
##########
@@ -119,8 +119,14 @@ def run_conan_install(minifi_options: MinifiOptions,
package_manager: PackageMan
print("Adding the nifi-conan remote failed")
return False
+ civetweb_defines = "'SOCKET_TIMEOUT_QUANTUM=200'"
+ if platform.system() != "Windows":
+ # use localtime_r/gmtime_r instead of the non-thread-safe
localtime/gmtime
+ civetweb_defines += ", 'REENTRANT_TIME'"
+ # access the stop flag atomically instead of as a plain volatile int,
which is a data race between mg_stop() and the civetweb threads
+ civetweb_defines += ", 'STOP_FLAG_NEEDS_LOCK'"
Review Comment:
This is a pre-existing issue (we did not apply our earlier patch in Conan
builds, either), and the new patch is not vital, it mainly serves to silence
the TSan warning. But the comment is valid, I have created a ticket to address
it later: https://issues.apache.org/jira/browse/MINIFICPP-2951.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]