fgerlits opened a new pull request, #2310: URL: https://github.com/apache/nifi-minifi-cpp/pull/2310
Fix some issues found by the ThreadSanitizer: * fix a parent <-> child ProcessGroup potential lock ordering issue * fix a data race on HTTPClient::read_callback_ * make SchedulingAgent::admin_yield_duration_ and bored_yield_duration_ atomic to fix a data race * make FlowController::start_time_ atomic to fix a data race * build CivetWeb with the REENTRANT_TIME flag (use thread-safe localtime/gmtime functions) and the STOP_FLAG_NEEDS_LOCK flag (use an atomic stop flag instead of a volatile int) Fix some test issues: * fix a (test-only) use-after-free bug in ListenHTTPTests * fix a data race in RepoTests * upgrade Catch2 to 3.16.1 and set the thread_safe_assertions flag, as we are running assertions from non-main threads, mainly in tests using CivetServer * make the running_ flag atomic in OpcUaTestServer * fix the server/handler destruction order in some mock server classes * skip PublishKafkaTests because librdkafka uses C11 threads, which are not supported by TSan, yet * skip most of MemoryUsageTest, because memory usage under TSan is much higher * use STRICT_GSL_CHECKS=AUDIT in all CI jobs * add a free_disk_space step to all the memcheck jobs The ThreadSanitizer job uses Clang instead of GCC because moodycamel::ConcurrentQueue doesn't compile under GCC with -fsanitize=thread, but it does under Clang. The tsan.supp file was generated by Claude Opus 5.5; the rest of the code changes were created with varying amounts of help from Claude Opus 5.5. https://issues.apache.org/jira/browse/MINIFICPP-2877 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
