[ 
https://issues.apache.org/jira/browse/NIFI-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893206#comment-15893206
 ] 

ASF GitHub Bot commented on NIFI-3490:
--------------------------------------

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1530
  
    Thanks @pvillard31 . For the record, I know some people prefer the Java 8 
lambdas, and I come from a Ruby/Groovy background where I use closures and 
chained collection operations for everything, but there can be pitfalls to 
replacing concise traditional Java for:each loops with lambdas (see 
[performance 
issues](http://blog.takipi.com/benchmark-how-java-8-lambdas-and-streams-can-make-your-code-5-times-slower/)
 and [other 
concerns](https://stackoverflow.com/questions/16635398/java-8-iterable-foreach-vs-foreach-loop/20177092#20177092))
 in addition to providing a learning curve for future developers who are not 
familiar with the construct. 
    
    I'm not going to request changing this back, and after I do a final review 
& smoke test, I'll merge this, but in the future I don't think we need to be 
*as* aggressive about ensuring new code always uses the newest feature when the 
existing process is fine. 


> TLS Toolkit - define SAN in standalone mode
> -------------------------------------------
>
>                 Key: NIFI-3490
>                 URL: https://issues.apache.org/jira/browse/NIFI-3490
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Tools and Build
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Minor
>              Labels: tls-toolkit
>             Fix For: 1.2.0
>
>
> Following NIFI-3331, it would be useful to have the same option (add Subject 
> Alternative Names in certificates) when using the TLS toolkit in standalone 
> mode.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to