[
https://issues.apache.org/jira/browse/NIFI-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905188#comment-15905188
]
ASF GitHub Bot commented on NIFI-1131:
--------------------------------------
GitHub user josephxsxn opened a pull request:
https://github.com/apache/nifi/pull/1583
NIFI-1131 renamed relationships
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/josephxsxn/nifi NIFI-1131
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1583.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1583
----
commit 7a3dc0d96db303837a05ed7be1ddbe1916850d43
Author: Joseph Niemiec <jniemie8>
Date: 2017-03-09T19:48:12Z
NIFI-1131 renamed relationships
----
> InvokeHttp relationships don't match other processors
> -----------------------------------------------------
>
> Key: NIFI-1131
> URL: https://issues.apache.org/jira/browse/NIFI-1131
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Joseph Percivall
> Assignee: Joseph Niemiec
> Priority: Trivial
> Labels: newbie
>
> The current InvokeHttp relationships are "Original", "Response", "Retry", "No
> Retry" and "Failure". They should be renamed as such:
> "Original" -> "Success Request"
> "Response" -> stays same
> "Retry" -> "Retry Request"
> "No Retry" -> "No Retry Request"
> "Failure" -> "Failure Request"
> In other processors the "Original" relationship is the unmodified original
> flowfile but in InvokeHttp it is used as a destination for a modified
> request. In InvokeHttp the request flowfile coming in is routed to different
> relationships depending on the status code received and is modified with new
> attributes.
> This would be a breaking change and would be slated for 1.0.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
