[
https://issues.apache.org/jira/browse/NIFI-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906686#comment-15906686
]
ASF GitHub Bot commented on NIFI-1131:
--------------------------------------
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1583
@josephxsxn unfortunately making the change this way would be rather
disruptive to existing flows. We learned this lesson on PropertyDescriptor
object and for that we added an additional characteristic called 'displayName'.
What I'm suggesting is we do the same for Relationship.
By adding a 'displayName' we can allow developers to change/tweak that over
time whereas the 'name' cannot change once it is put out in a release unless
the change is made during a major release cycle and even then we should try to
minimize the frequency since it can make porting flows harder.
The bottom line is the 'name' is an important part of how we establish the
persistent knowledge of a connection between two components. If you look in
the flow.xml.gz of a flow with a connection you'll see the 'relationship' and
in it is the name of the source processors relationship used in that
connection. So, changing the 'name' breaks old flows. We can instead add
'displayName' and now that value is what will show up in the UI but is not what
is used for underlying persistence. By default the displayName if not set will
be whatever the name was (and vice versa) in the code just like
PropertyDescriptor but over time the value of name and displayName can diverge
and that will be ok provided the Relationship still means what it meant before.
I'll stop rambling. Does this make sense?
> InvokeHttp relationships don't match other processors
> -----------------------------------------------------
>
> Key: NIFI-1131
> URL: https://issues.apache.org/jira/browse/NIFI-1131
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Joseph Percivall
> Assignee: Joseph Niemiec
> Priority: Trivial
> Labels: newbie
>
> The current InvokeHttp relationships are "Original", "Response", "Retry", "No
> Retry" and "Failure". They should be renamed as such:
> "Original" -> "Success Request"
> "Response" -> stays same
> "Retry" -> "Retry Request"
> "No Retry" -> "No Retry Request"
> "Failure" -> "Failure Request"
> In other processors the "Original" relationship is the unmodified original
> flowfile but in InvokeHttp it is used as a destination for a modified
> request. In InvokeHttp the request flowfile coming in is routed to different
> relationships depending on the status code received and is modified with new
> attributes.
> This would be a breaking change and would be slated for 1.0.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
