Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1580#discussion_r106409739
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/FileSystemRepository.java
 ---
    @@ -392,8 +399,11 @@ public long getContainerUsableSpace(String 
containerName) throws IOException {
             if (path == null) {
                 throw new IllegalArgumentException("No container exists with 
name " + containerName);
             }
    -
    -        return Files.getFileStore(path).getUsableSpace();
    +        long usableSpace=path.toFile().getUsableSpace();
    +        if(usableSpace==0) {
    +            throw new RuntimeException("System returned usable space of 
the partition for " + containerName + " is zero byte. Nifi can not create a 
zero sized FileSystemRepository");
    --- End diff --
    
    We shouldn't be throwing an Exception here at all. If the content 
repository runs out of disk space, it will return 0. This is a very valid value 
and should not result in an Exception being thrown.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to