Github user PuspenduBanerjee commented on the issue:
https://github.com/apache/nifi/pull/1580
sure. I shall modify those and check in back.
Thanks & Regards,
Puspendu Banerjee
On Thu, Mar 16, 2017 at 11:59 AM, Michael Moser <[email protected]>
wrote:
> *@mosermw* commented on this pull request.
> ------------------------------
>
> In nifi-nar-bundles/nifi-framework-bundle/nifi-
> framework/nifi-framework-core/src/main/java/org/apache/nifi/
> controller/repository/FileSystemRepository.java
> <https://github.com/apache/nifi/pull/1580#discussion_r106473572>:
>
> > @@ -392,8 +399,11 @@ public long getContainerUsableSpace(String
containerName) throws IOException {
> if (path == null) {
> throw new IllegalArgumentException("No container exists with
name " + containerName);
> }
> -
> - return Files.getFileStore(path).getUsableSpace();
> + long usableSpace=path.toFile().getUsableSpace();
> + if(usableSpace==0) {
> + throw new RuntimeException("System returned usable space of
the partition for " + containerName + " is zero byte. Nifi can not create a
zero sized FileSystemRepository");
>
> Hi @PuspenduBanerjee <https://github.com/PuspenduBanerjee>, since
> getContainerCapacity() and getContainerUsableSpace() are public methods, I
> would prefer that we try to maintain their existing contract. I would
> prefer to avoid even an extremely small chance of a RuntimeException.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/nifi/pull/1580#discussion_r106473572>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AE2raFwemv-xHZFjHDmD_HfPuAoGZvW4ks5rmWpegaJpZM4MXrCF>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
