[ 
https://issues.apache.org/jira/browse/NIFI-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975629#comment-15975629
 ] 

ASF GitHub Bot commented on NIFI-3682:
--------------------------------------

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1682#discussion_r112324751
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/schema/access/SchemaNameAsAttribute.java
 ---
    @@ -0,0 +1,46 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.schema.access;
    +
    +import java.io.IOException;
    +import java.io.OutputStream;
    +import java.util.Collections;
    +import java.util.Map;
    +import java.util.Optional;
    +
    +import org.apache.nifi.serialization.record.RecordSchema;
    +import org.apache.nifi.serialization.record.SchemaIdentifier;
    +
    +public class SchemaNameAsAttribute implements SchemaAccessWriter {
    --- End diff --
    
    what about 'SchemaReferenceAsAttribute' and we could support lookup via 
schema name, schema identifier and version.  Also, it means we'd supply each of 
these as flowfile attributes when we have them?


> Add "Schema Access Strategy" to Record Readers and Writers
> ----------------------------------------------------------
>
>                 Key: NIFI-3682
>                 URL: https://issues.apache.org/jira/browse/NIFI-3682
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>             Fix For: 1.2.0
>
>
> Currently the record readers are mostly configured with a Schema Registry 
> service and the name of the schema. We should instead allow user to choose 
> one of several strategies for determining the schema: Schema Registry + 
> schema.name attribute, Schema Registry + identifier and version embedded at 
> start of record/stream, avro.schema attribute, embedded schema for cases like 
> Avro where the schema can be embedded in the content itself.
> On the writer side, we should also expose these options in order to convey 
> the schema information to others.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to