[ 
https://issues.apache.org/jira/browse/NIFI-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976639#comment-15976639
 ] 

ASF GitHub Bot commented on NIFI-3682:
--------------------------------------

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1682#discussion_r112444804
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/avro/AvroReader.java
 ---
    @@ -19,31 +19,47 @@
     
     import java.io.IOException;
     import java.io.InputStream;
    +import java.util.ArrayList;
    +import java.util.List;
     
     import org.apache.nifi.annotation.documentation.CapabilityDescription;
     import org.apache.nifi.annotation.documentation.Tags;
    -import org.apache.nifi.controller.AbstractControllerService;
    +import org.apache.nifi.components.AllowableValue;
     import org.apache.nifi.flowfile.FlowFile;
     import org.apache.nifi.logging.ComponentLog;
    +import org.apache.nifi.schema.access.SchemaNotFoundException;
     import org.apache.nifi.serialization.MalformedRecordException;
     import org.apache.nifi.serialization.RecordReader;
    -import org.apache.nifi.serialization.RowRecordReaderFactory;
    -import org.apache.nifi.serialization.record.RecordSchema;
    +import org.apache.nifi.serialization.RecordReaderFactory;
    +import org.apache.nifi.serialization.SchemaRegistryService;
     
     @Tags({"avro", "parse", "record", "row", "reader", "delimited", "comma", 
"separated", "values"})
     @CapabilityDescription("Parses Avro data and returns each Avro record as 
an separate Record object. The Avro data must contain "
    --- End diff --
    
    Good catch. Will update.


> Add "Schema Access Strategy" to Record Readers and Writers
> ----------------------------------------------------------
>
>                 Key: NIFI-3682
>                 URL: https://issues.apache.org/jira/browse/NIFI-3682
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>             Fix For: 1.2.0
>
>
> Currently the record readers are mostly configured with a Schema Registry 
> service and the name of the schema. We should instead allow user to choose 
> one of several strategies for determining the schema: Schema Registry + 
> schema.name attribute, Schema Registry + identifier and version embedded at 
> start of record/stream, avro.schema attribute, embedded schema for cases like 
> Avro where the schema can be embedded in the content itself.
> On the writer side, we should also expose these options in order to convey 
> the schema information to others.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to