[
https://issues.apache.org/jira/browse/NIFI-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990730#comment-15990730
]
ASF GitHub Bot commented on NIFI-3609:
--------------------------------------
Github user jdye64 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1597#discussion_r114116276
--- Diff:
nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketClient.java
---
@@ -81,6 +87,16 @@
.defaultValue("3 sec")
.build();
+ public static final PropertyDescriptor SESSION_MAINTENANCE_INTERVAL =
new PropertyDescriptor.Builder()
+ .name("session-maintenance-interval")
+ .displayName("Session Maintenance Interval")
+ .description("The interval between session maintenance
activities.")
+ .required(true)
+ .expressionLanguageSupported(true)
+ .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
+ .defaultValue("10 sec")
--- End diff --
Since this is invoking maintainSessions() and that is effectively
reconnecting sessions would it make sense to make this default value less than
the default value of CONNECTION_TIMEOUT just so by default this would prevent
connections from timing out at all? This would help in the case that the client
becomes inactive for longer than the default CONNECTION_TIMEOUT and help ensure
messages are not missed being delivered to the client.
> ConnectWebSocket should be able to reconnect automatically
> ----------------------------------------------------------
>
> Key: NIFI-3609
> URL: https://issues.apache.org/jira/browse/NIFI-3609
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.1.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> WebSocket connection can be extended by trigger PutWebSocket periodically
> (typically with empty message), but it doesn't help when server goes down.
> Currently if a server restarted, ConnectWebSocket has to be restarted
> manually to establish new connection.
> Ideally, this situation should be recovered automatically. If existing
> session ids can be reused, it'd be even better as it recovers transparently.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
