[ 
https://issues.apache.org/jira/browse/NIFI-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992617#comment-15992617
 ] 

ASF GitHub Bot commented on NIFI-3609:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1597#discussion_r114280064
  
    --- Diff: 
nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketClient.java
 ---
    @@ -81,6 +87,16 @@
                 .defaultValue("3 sec")
                 .build();
     
    +    public static final PropertyDescriptor SESSION_MAINTENANCE_INTERVAL = 
new PropertyDescriptor.Builder()
    +            .name("session-maintenance-interval")
    +            .displayName("Session Maintenance Interval")
    +            .description("The interval between session maintenance 
activities.")
    --- End diff --
    
    Good point, I added more description what this maintenance does. Thanks!


> ConnectWebSocket should be able to reconnect automatically
> ----------------------------------------------------------
>
>                 Key: NIFI-3609
>                 URL: https://issues.apache.org/jira/browse/NIFI-3609
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.1.0
>            Reporter: Koji Kawamura
>            Assignee: Koji Kawamura
>
> WebSocket connection can be extended by trigger PutWebSocket periodically 
> (typically with empty message), but it doesn't help when server goes down.
> Currently if a server restarted, ConnectWebSocket has to be restarted 
> manually to establish new connection.
> Ideally, this situation should be recovered automatically. If existing 
> session ids can be reused, it'd be even better as it recovers transparently.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to