[
https://issues.apache.org/jira/browse/NIFI-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996242#comment-15996242
]
ASF GitHub Bot commented on NIFI-3795:
--------------------------------------
GitHub user jvwing opened a pull request:
https://github.com/apache/nifi/pull/1750
NIFI-3795 Activate generateArchives outside git
This change to the nifi-assembly POM activates the generateArchives profile
when the build is run outside a git repository. This is necessary so both the
generateArchives and build-info-no-git are activated at the same time.
----
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jvwing/nifi
NIFI-3795-nifi-assembly-no-formats-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1750.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1750
----
commit 5fa18c5cd351cd0cbe70bbbfe56824cff786f499
Author: James Wing <[email protected]>
Date: 2017-05-04T02:11:54Z
NIFI-3795 Activate generateArchives outside git
----
> nifi-assembly fails with "no formats specified" error
> -----------------------------------------------------
>
> Key: NIFI-3795
> URL: https://issues.apache.org/jira/browse/NIFI-3795
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Bryan Bende
> Priority: Blocker
> Fix For: 1.2.0
>
>
> After staging the 1.2.0 RC1 artifacts, I then downloaded the source zip from
> the Nexus staging repo, unzipped it and ran "mvn clean install -DskipTests"
> to verify that it would build. I encountered the below error:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:2.5.2:single (make shared
> resource) on project nifi-assembly: No formats specified in the execution
> parameters or the assembly descriptor. -> [Help 1]
> After some debugging it was determined that one difference between this build
> and the previous build that staged the artifacts, is that this build was not
> within a git repo where as the other one was.
> After running git init, adding all files, and making a commit, then the build
> passed. Still unclear as to why being in a git repo matters here, although
> every NAR now tries to use the git info from the buildnumber plugin to filter
> into the MANIFEST files.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
